Refresh rate-limits watch for account and secret changes#284
Merged
Conversation
CoverageTotal line coverage: 86.53% (59624/68902 lines hit). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh rate-limits watch for account and secret changes
Summary
diag rate-limits --async --watchnow refreshes the active-account highlight and secret list every watch round. This lets long-running watch sessions reflectauth use ...account switches and secret add/remove changes without restarting.Changes
CODEX_SECRET_DIReach watch round instead of using a startup-only secret snapshot.auth use.CODEX_RATE_LIMITS_WATCH_INTERVAL_SECONDSfor test-time watch interval override.Testing
cargo test -p nils-codex-cli rate_limits_async -- --nocapture(pass)./.agents/skills/nils-cli-verify-required-checks/scripts/nils-cli-verify-required-checks.sh(pass)mkdir -p target/coverage && cargo llvm-cov nextest --profile ci --workspace --lcov --output-path target/coverage/lcov.info --fail-under-lines 85 && scripts/ci/coverage-summary.sh target/coverage/lcov.info(pass, 86.57%)Risk / Notes